BUG Measurement model (measurementmodel.cpp)

Hi All,

We think we have found a possible BUG in the BFL source code (measurementmodel.cpp):

template<typename MeasVar, typename StateVar> MeasVar
MeasurementModel<MeasVar,StateVar>::Simulate(const StateVar& x,
int sampling_method,
void * sampling_args)
{
assert(_systemWithoutSensorParams == true);
_MeasurementPdf->ConditionalArgumentSet(0,x);
Sample<StateVar> Simulated(MeasurementSizeGet());
_MeasurementPdf->SampleFrom(Simulated, sampling_method,sampling_args);
MeasVar result = Simulated.ValueGet();
return result;
}

Shouldn't the highlighted "StateVar" be "MeasVar"? How can a Sample of StateVar return a MeasVar type when MeasVar != StateVar?

Thanks,

Kind regards,

Rein Appeldoorn
This message may contain information that is not intended for you. If you are not the addressee or if this message was sent to you by mistake, you are requested to inform the sender and delete the message. TNO accepts no liability for the content of this e-mail, for the manner in which you use it and for damage of any kind resulting from the risks inherent to the electronic transmission of messages.
_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl

BUG Measurement model (measurementmodel.cpp)

Hi Rein,

On Fri, Jul 10, 2015 at 2:54 PM, Appeldoorn, P.W. (Rein)
<rein [dot] appeldoorn [..] ...> wrote:
> Hi All,
>
> We think we have found a possible BUG in the BFL source code (measurementmodel.cpp):

[...]
> Shouldn't the highlighted "StateVar" be "MeasVar"? How can a Sample of StateVar return a MeasVar type when MeasVar != StateVar?

[patience is a virtue :-/ ]

Fixed by https://gitlab.mech.kuleuven.be/rob-estimation/orocos-bayesian-filtering...

(stay tuned for more info on the new repository location etc :-)

BR,

Klaas
_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl

BUG Measurement model (measurementmodel.cpp)

Hi Rein,

On Fri, Jul 10, 2015 at 2:54 PM, Appeldoorn, P.W. (Rein)
<rein [dot] appeldoorn [..] ...> wrote:
> Hi All,
>
> We think we have found a possible BUG in the BFL source code (measurementmodel.cpp):
>
> template<typename MeasVar, typename StateVar> MeasVar
> MeasurementModel<MeasVar,StateVar>::Simulate(const StateVar& x,
> int sampling_method,
> void * sampling_args)
> {
> assert(_systemWithoutSensorParams == true);
> _MeasurementPdf->ConditionalArgumentSet(0,x);
> Sample<StateVar> Simulated(MeasurementSizeGet());
> _MeasurementPdf->SampleFrom(Simulated, sampling_method,sampling_args);
> MeasVar result = Simulated.ValueGet();
> return result;
> }
>
> Shouldn't the highlighted "StateVar" be "MeasVar"? How can a Sample of StateVar return a MeasVar type when MeasVar != StateVar?

It seems like your html mail was textified by mailman, and as such
nothing is highlighted :-)

However, I assume you are referring to Sample<StateVar>
Simulated(MeasurementSizeGet());
Which version of BFL are you using? At least in v0.8.0 I can confirm
that the bug is at least present (the overloaded method just above it
doesn't suffer from the bug).

Unfortunately, there are currently some problems in accessing the BFL
source code that do not seem to get solved. Maybe I should start a
fork of the code myself in order to get things moving...

Thx for reporting!

Klaas
_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl

BUG Measurement model (measurementmodel.cpp)

Hi Klaas,

I'm using 0.7.0 but the bug still seems to be present in 0.8.0. Maybe an idea to put the source code on github?

-Rein

-----Original Message-----
From: Klaas Gadeyne [mailto:klaas [dot] gadeyne [..] ...]
Sent: vrijdag 10 juli 2015 15:33
To: Appeldoorn, P.W. (Rein)
Cc: bfl [..] ...
Subject: Re: [BFL] BUG Measurement model (measurementmodel.cpp)

Hi Rein,

On Fri, Jul 10, 2015 at 2:54 PM, Appeldoorn, P.W. (Rein) <rein [dot] appeldoorn [..] ...> wrote:
> Hi All,
>
> We think we have found a possible BUG in the BFL source code (measurementmodel.cpp):
>
> template<typename MeasVar, typename StateVar> MeasVar
> MeasurementModel<MeasVar,StateVar>::Simulate(const StateVar& x,
> int sampling_method,
> void * sampling_args) {
> assert(_systemWithoutSensorParams == true);
> _MeasurementPdf->ConditionalArgumentSet(0,x);
> Sample<StateVar> Simulated(MeasurementSizeGet());
> _MeasurementPdf->SampleFrom(Simulated, sampling_method,sampling_args);
> MeasVar result = Simulated.ValueGet();
> return result;
> }
>
> Shouldn't the highlighted "StateVar" be "MeasVar"? How can a Sample of StateVar return a MeasVar type when MeasVar != StateVar?

It seems like your html mail was textified by mailman, and as such nothing is highlighted :-)

However, I assume you are referring to Sample<StateVar> Simulated(MeasurementSizeGet()); Which version of BFL are you using? At least in v0.8.0 I can confirm that the bug is at least present (the overloaded method just above it doesn't suffer from the bug).

Unfortunately, there are currently some problems in accessing the BFL source code that do not seem to get solved. Maybe I should start a fork of the code myself in order to get things moving...

Thx for reporting!

Klaas
This message may contain information that is not intended for you. If you are not the addressee or if this message was sent to you by mistake, you are requested to inform the sender and delete the message. TNO accepts no liability for the content of this e-mail, for the manner in which you use it and for damage of any kind resulting from the risks inherent to the electronic transmission of messages.
_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl