Hi Ruben,
On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
>we've cleanup our fork to remove the ugly guard changes we did. But we
>did do a catkinization of rFSM. It just adds functionality, we do not
>break any old use-cases. It just makes it possible now to include rFSM
>in a catkin workspace and have all the LUA paths set up automatically.
I'm not very enthusiastic about this patch, IMNSHO it's plain wrong that
a generic software library needs to be changed for use in a specific
framework.
>Using this patch we can also seamlessly release rFSM into the ROS
>ecosystem. (apt-get install ros-hydro-rFSM)
>
>pull request is available here: https://github.com/kmarkus/rFSM/pull/4
I've merged it, since it seems to make your and other users life
easier. But I think the long term goal should be to have a generic
non-ros debian package.
Markus
rFSM catkinization
On Fri, 14 Feb 2014, Markus Klotzbuecher wrote:
> Hi Ruben,
>
> On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
>
>> we've cleanup our fork to remove the ugly guard changes we did. But we
>> did do a catkinization of rFSM. It just adds functionality, we do not
>> break any old use-cases. It just makes it possible now to include rFSM
>> in a catkin workspace and have all the LUA paths set up automatically.
>
> I'm not very enthusiastic about this patch, IMNSHO it's plain wrong that
> a generic software library needs to be changed for use in a specific
> framework.
I fully agree! This is an unmaintainable path...
>> Using this patch we can also seamlessly release rFSM into the ROS
>> ecosystem. (apt-get install ros-hydro-rFSM)
>>
>> pull request is available here: https://github.com/kmarkus/rFSM/pull/4
>
> I've merged it, since it seems to make your and other users life
> easier. But I think the long term goal should be to have a generic
> non-ros debian package.
>
> Markus
Herman
rFSM catkinization
>
> > I'm not very enthusiastic about this patch, IMNSHO it's plain wrong that
> > a generic software library needs to be changed for use in a specific
> > framework.
>
> I fully agree! This is an unmaintainable path...
>
It is obviously unmaintainable as the orocos packages already migrated into
rosbuild, then from rosbuild to catkin for the sake of ROS compatibility.
But it seems that spending time on build systems is fun [/sarcasm]
Sylvain
2014-02-14 9:39 GMT+01:00 Herman Bruyninckx <
Herman [dot] Bruyninckx [..] ...>:
> On Fri, 14 Feb 2014, Markus Klotzbuecher wrote:
>
> > Hi Ruben,
> >
> > On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
> >
> >> we've cleanup our fork to remove the ugly guard changes we did. But we
> >> did do a catkinization of rFSM. It just adds functionality, we do not
> >> break any old use-cases. It just makes it possible now to include rFSM
> >> in a catkin workspace and have all the LUA paths set up automatically.
> >
> > I'm not very enthusiastic about this patch, IMNSHO it's plain wrong that
> > a generic software library needs to be changed for use in a specific
> > framework.
>
> I fully agree! This is an unmaintainable path...
>
> >> Using this patch we can also seamlessly release rFSM into the ROS
> >> ecosystem. (apt-get install ros-hydro-rFSM)
> >>
> >> pull request is available here: https://github.com/kmarkus/rFSM/pull/4
> >
> > I've merged it, since it seems to make your and other users life
> > easier. But I think the long term goal should be to have a generic
> > non-ros debian package.
> >
> > Markus
>
> Herman
> --
> Orocos-Dev mailing list
> Orocos-Dev [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
>
rFSM catkinization
On Fri, May 16, 2014 at 4:14 PM, Sylvain Joyeux <sylvain [dot] joyeux [..] ...>wrote:
> > I'm not very enthusiastic about this patch, IMNSHO it's plain wrong that
>> > a generic software library needs to be changed for use in a specific
>> > framework.
>>
>> I fully agree! This is an unmaintainable path...
>>
> It is obviously unmaintainable as the orocos packages already migrated
> into rosbuild, then from rosbuild to catkin for the sake of ROS
> compatibility. But it seems that spending time on build systems is fun
> [/sarcasm]
>
I'd say that the intrusiveness of ROS compatibility has improved
substantially since rosbuild. If adding the package.xml file to an upstream
repository is undesirable, bloom also allows to "inject" it into the
release (not upstream) repository. More info here:
http://wiki.ros.org/bloom/Tutorials/ReleaseThirdParty#Modifying_the_Rele...
Cheers,
Adolfo.
>
> Sylvain
>
>
> 2014-02-14 9:39 GMT+01:00 Herman Bruyninckx <
> Herman [dot] Bruyninckx [..] ...>:
>
>> On Fri, 14 Feb 2014, Markus Klotzbuecher wrote:
>>
>> > Hi Ruben,
>> >
>> > On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
>> >
>> >> we've cleanup our fork to remove the ugly guard changes we did. But we
>> >> did do a catkinization of rFSM. It just adds functionality, we do not
>> >> break any old use-cases. It just makes it possible now to include rFSM
>> >> in a catkin workspace and have all the LUA paths set up automatically.
>> >
>> > I'm not very enthusiastic about this patch, IMNSHO it's plain wrong that
>> > a generic software library needs to be changed for use in a specific
>> > framework.
>>
>> I fully agree! This is an unmaintainable path...
>>
>> >> Using this patch we can also seamlessly release rFSM into the ROS
>> >> ecosystem. (apt-get install ros-hydro-rFSM)
>> >>
>> >> pull request is available here: https://github.com/kmarkus/rFSM/pull/4
>> >
>> > I've merged it, since it seems to make your and other users life
>> > easier. But I think the long term goal should be to have a generic
>> > non-ros debian package.
>> >
>> > Markus
>>
>> Herman
>> --
>> Orocos-Dev mailing list
>> Orocos-Dev [..] ...
>> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
>>
>
>
> --
> Orocos-Dev mailing list
> Orocos-Dev [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
>
>
rFSM catkinization
>
>
> > Hi Ruben,
> >
> > On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
> >
> >> we've cleanup our fork to remove the ugly guard changes we did. But we
> >> did do a catkinization of rFSM. It just adds functionality, we do not
> >> break any old use-cases.
>
That is not true. It also breaks also the compatibility w.r.t. old ROS
versions (Fuerte, Electric...)...(Nick and me just had this experience).
Please, fix it....
- Enea
rFSM catkinization
Hi Enea,
On Tue, Feb 18, 2014 at 5:37 PM, Enea Scioni <scnnee [..] ...> wrote:
>>
>> > Hi Ruben,
>> >
>> > On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
>> >
>> >> we've cleanup our fork to remove the ugly guard changes we did. But we
>> >> did do a catkinization of rFSM. It just adds functionality, we do not
>> >> break any old use-cases.
>
> That is not true. It also breaks also the compatibility w.r.t. old ROS
> versions (Fuerte, Electric...)...(Nick and me just had this experience).
> Please, fix it....
we forgot that people are still using those old ROS distributions ;),
we will resurrect the manifest.xml for you guys.
Ruben
> - Enea
>
> --
> Orocos-Dev mailing list
> Orocos-Dev [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
>
rFSM catkinization
>>> >> we've cleanup our fork to remove the ugly guard changes we did. But we
>>> >> did do a catkinization of rFSM. It just adds functionality, we do not
>>> >> break any old use-cases.
>>
>> That is not true. It also breaks also the compatibility w.r.t. old ROS
>> versions (Fuerte, Electric...)...(Nick and me just had this experience).
>> Please, fix it....
>
> we forgot that people are still using those old ROS distributions ;),
Not old...stable! :-)
> we will resurrect the manifest.xml for you guys.
Thanks!
- Enea
rFSM catkinization
On Mi, Feb 19, 2014 at 02:41:32 +0100, Ruben Smits wrote:
>Hi Enea,
>
>On Tue, Feb 18, 2014 at 5:37 PM, Enea Scioni <scnnee [..] ...> wrote:
>>>
>>> > Hi Ruben,
>>> >
>>> > On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
>>> >
>>> >> we've cleanup our fork to remove the ugly guard changes we did. But we
>>> >> did do a catkinization of rFSM. It just adds functionality, we do not
>>> >> break any old use-cases.
>>
>> That is not true. It also breaks also the compatibility w.r.t. old ROS
>> versions (Fuerte, Electric...)...(Nick and me just had this experience).
>> Please, fix it....
>
>we forgot that people are still using those old ROS distributions ;),
>we will resurrect the manifest.xml for you guys.
Argh. In five years we'll have more rosbuild crap in the source tree
than source. :(
Markus
rFSM catkinization
2014-02-19 14:41 GMT+01:00 Ruben Smits <ruben [dot] smits [..] ...>:
> Hi Enea,
>
> On Tue, Feb 18, 2014 at 5:37 PM, Enea Scioni <scnnee [..] ...> wrote:
> >>
> >> > Hi Ruben,
> >> >
> >> > On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
> >> >
> >> >> we've cleanup our fork to remove the ugly guard changes we did. But
> we
> >> >> did do a catkinization of rFSM. It just adds functionality, we do not
> >> >> break any old use-cases.
> >
> > That is not true. It also breaks also the compatibility w.r.t. old ROS
> > versions (Fuerte, Electric...)...(Nick and me just had this experience).
> > Please, fix it....
>
> we forgot that people are still using those old ROS distributions ;),
> we will resurrect the manifest.xml for you guys.
>
>
Thanks !!!! :D
> Ruben
>
> > - Enea
> >
> > --
> > Orocos-Dev mailing list
> > Orocos-Dev [..] ...
> > http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
> >
>
>
>
> --
> Ruben Smits, CTO
> +32 479 511 786
> Intermodalics - Kapeldreef 60, 3001 Heverlee - BELGIUM
> www.intermodalics.eu
>
>
> ---------------------------------------------------------------------------------------------------------------------------------------
> This email and any attached files are confidential and may be legally
> privileged. Any copy, print or forward of this email, without the
> agreement of sender or addressee, is strictly prohibited. Misuse is a
> violation of the law on personal data protection (D. Lgs. 196/2003)
> and on secrecy of correspondence (art. 616 cp). If you have received
> this transmission in error please notify the sender immediately and
> then delete this email and any attached files.
> --
> Orocos-Dev mailing list
> Orocos-Dev [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
>
rFSM catkinization
Hi Marcus,
On Fri, Feb 14, 2014 at 9:32 AM, Markus Klotzbuecher
<markus [dot] klotzbuecher [..] ...> wrote:
> Hi Ruben,
>
> On Do, Feb 13, 2014 at 04:28:47 +0100, Ruben Smits wrote:
>
>>we've cleanup our fork to remove the ugly guard changes we did. But we
>>did do a catkinization of rFSM. It just adds functionality, we do not
>>break any old use-cases. It just makes it possible now to include rFSM
>>in a catkin workspace and have all the LUA paths set up automatically.
>
> I'm not very enthusiastic about this patch, IMNSHO it's plain wrong that
> a generic software library needs to be changed for use in a specific
> framework.
>
>>Using this patch we can also seamlessly release rFSM into the ROS
>>ecosystem. (apt-get install ros-hydro-rFSM)
>>
>>pull request is available here: https://github.com/kmarkus/rFSM/pull/4
>
> I've merged it, since it seems to make your and other users life
> easier. But I think the long term goal should be to have a generic
> non-ros debian package.
I can see why you're not enthousiastic, but with this change you do
not only get a (ros)-debian, but also a Fedora/RHEL (ros)-rpm and a
(ros)-MacPort.
Thanks for merging!!!
> Markus
Ruben