bugfix for rfsm_rtt

Hi,

in the rFSM package is the file rfsm_rtt.lua

when a non string value is send to the gen_write_fqn, the following error occurs:
error calling function startHook: /home/u0065688/ros_workspace/rFSM/rfsm_rtt.lua:119: attempt to call local 'type' (a string value)

which is caused by the fact that the check type(filter)~='function' fails
this is due to the fact that the function 'type' is overwritten by the variable 'type'

in attachment a patch that changes the variable name to atype

problem that still remains:
the error message is constructed as a concatenation of the variable atype to the message, but if atype is NOT a string (the reason for the error btw), this can't be done by
"blabla" .. atype, it will error on this!
atype has to be converted to a string first!

nick

bugfix for rfsm_rtt

On 01/27/2012 05:56 PM, Dominick Vanthienen wrote:
> Hi,
>
> in the rFSM package is the file rfsm_rtt.lua
>
> when a non string value is send to the gen_write_fqn, the following error occurs:
> error calling function startHook: /home/u0065688/ros_workspace/rFSM/rfsm_rtt.lua:119: attempt to call local 'type' (a string value)
>
> which is caused by the fact that the check type(filter)~='function' fails
> this is due to the fact that the function 'type' is overwritten by the variable 'type'
>
> in attachment a patch that changes the variable name to atype
>
> problem that still remains:
> the error message is constructed as a concatenation of the variable atype to the message, but if atype is NOT a string (the reason for the error btw), this can't be done by
> "blabla" .. atype, it will error on this!
> atype has to be converted to a string first!
>
another problem that remains:
the function checks whether the type == string, but it should check for all loaded 'string like' somehow
>
> nick
>

bugfix for rfsm_rtt

In the attachment you can find a patch that resolves both issues.

Eli

On Fri, Jan 27, 2012 at 6:19 PM, Dominick Vanthienen <
dominick [dot] vanthienen [..] ...> wrote:

>
>
> On 01/27/2012 05:56 PM, Dominick Vanthienen wrote:
> > Hi,
> >
> > in the rFSM package is the file rfsm_rtt.lua
> >
> > when a non string value is send to the gen_write_fqn, the following
> error occurs:
> > error calling function startHook:
> /home/u0065688/ros_workspace/rFSM/rfsm_rtt.lua:119: attempt to call local
> 'type' (a string value)
> >
> > which is caused by the fact that the check type(filter)~='function' fails
> > this is due to the fact that the function 'type' is overwritten by the
> variable 'type'
> >
> > in attachment a patch that changes the variable name to atype
> >
> > problem that still remains:
> > the error message is constructed as a concatenation of the variable
> atype to the message, but if atype is NOT a string (the reason for the
> error btw), this can't be done by
> > "blabla" .. atype, it will error on this!
> > atype has to be converted to a string first!
> >
> another problem that remains:
> the function checks whether the type == string, but it should check for
> all loaded 'string like' somehow
> >
> > nick
> >
> --
> Orocos-Users mailing list
> Orocos-Users [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>

bugfix for rfsm_rtt

Hi Guys,

On Fri, Feb 03, 2012 at 02:26:23PM +0100, Eli Reekmans wrote:
> In the attachment you can find a patch that resolves both issues.

Is anyone actually using the filter function at all? In my dev branch
I have removed it entirely, so if you do use it, please speak up...

Markus