There is a thread going on to change the default name of the
DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
Since component names are case sensitive, this would break about every
lua script that contains the lines:
tc = rttl.getTC()
depl = tc:getPeer("deployer")
We could push this to the 2.6.0 branch and document it as a Caveat in
the release notes. We could also fabricate a script to fixup your
packages.
Since Lua deployment is picking up, it's only getting more difficult
in the future to make such a change. So here's a chance to formulate
your opinion on this (+1/-1).
Peter
Lua users: please read this
On Fri, Dec 14, 2012 at 10:57:44AM +0100, Peter Soetens wrote:
> There is a thread going on to change the default name of the
> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> Since component names are case sensitive, this would break about every
> lua script that contains the lines:
>
> tc = rttl.getTC()
> depl = tc:getPeer("deployer")
>
> We could push this to the 2.6.0 branch and document it as a Caveat in
> the release notes. We could also fabricate a script to fixup your
> packages.
>
> Since Lua deployment is picking up, it's only getting more difficult
> in the future to make such a change. So here's a chance to formulate
> your opinion on this (+1/-1).
Thanks to everyone for voting and agreeing to fix this! I'll prepare a
patch and a fixup script. And we'll send a last warning before the
final push...
Markus
Lua users: please read this
On Sat, Dec 15, 2012 at 12:56 PM, Markus Klotzbuecher
<markus [dot] klotzbuecher [..] ...> wrote:
> On Fri, Dec 14, 2012 at 10:57:44AM +0100, Peter Soetens wrote:
>> There is a thread going on to change the default name of the
>> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
>> Since component names are case sensitive, this would break about every
>> lua script that contains the lines:
>>
>> tc = rttl.getTC()
>> depl = tc:getPeer("deployer")
>>
>> We could push this to the 2.6.0 branch and document it as a Caveat in
>> the release notes. We could also fabricate a script to fixup your
>> packages.
>>
>> Since Lua deployment is picking up, it's only getting more difficult
>> in the future to make such a change. So here's a chance to formulate
>> your opinion on this (+1/-1).
>
> Thanks to everyone for voting and agreeing to fix this! I'll prepare a
> patch and a fixup script. And we'll send a last warning before the
> final push...
Paul's patch already contains the renaming, being the cause of this
discussion, I think he deserves the credit :-)
http://bugs.orocos.org/show_bug.cgi?id=950#c8
Peter
Lua users: please read this
On Sat, Dec 15, 2012 at 09:42:29PM +0100, Peter Soetens wrote:
> On Sat, Dec 15, 2012 at 12:56 PM, Markus Klotzbuecher
> <markus [dot] klotzbuecher [..] ...> wrote:
> > On Fri, Dec 14, 2012 at 10:57:44AM +0100, Peter Soetens wrote:
> >> There is a thread going on to change the default name of the
> >> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> >> Since component names are case sensitive, this would break about every
> >> lua script that contains the lines:
> >>
> >> tc = rttl.getTC()
> >> depl = tc:getPeer("deployer")
> >>
> >> We could push this to the 2.6.0 branch and document it as a Caveat in
> >> the release notes. We could also fabricate a script to fixup your
> >> packages.
> >>
> >> Since Lua deployment is picking up, it's only getting more difficult
> >> in the future to make such a change. So here's a chance to formulate
> >> your opinion on this (+1/-1).
> >
> > Thanks to everyone for voting and agreeing to fix this! I'll prepare a
> > patch and a fixup script. And we'll send a last warning before the
> > final push...
>
> Paul's patch already contains the renaming, being the cause of this
> discussion, I think he deserves the credit :-)
>
> http://bugs.orocos.org/show_bug.cgi?id=950#c8
Absolutely, I missed that. But there are a couple other occurences, in
rttlib, etc. that need fixing, so I'll apply his first and the other
on top.
Markus
Lua users: please read this
On Sat, Dec 15, 2012 at 10:21:15PM +0100, Markus Klotzbuecher wrote:
> On Sat, Dec 15, 2012 at 09:42:29PM +0100, Peter Soetens wrote:
> > On Sat, Dec 15, 2012 at 12:56 PM, Markus Klotzbuecher
> > <markus [dot] klotzbuecher [..] ...> wrote:
> > > On Fri, Dec 14, 2012 at 10:57:44AM +0100, Peter Soetens wrote:
> > >> There is a thread going on to change the default name of the
> > >> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> > >> Since component names are case sensitive, this would break about every
> > >> lua script that contains the lines:
> > >>
> > >> tc = rttl.getTC()
> > >> depl = tc:getPeer("deployer")
> > >>
> > >> We could push this to the 2.6.0 branch and document it as a Caveat in
> > >> the release notes. We could also fabricate a script to fixup your
> > >> packages.
> > >>
> > >> Since Lua deployment is picking up, it's only getting more difficult
> > >> in the future to make such a change. So here's a chance to formulate
> > >> your opinion on this (+1/-1).
> > >
> > > Thanks to everyone for voting and agreeing to fix this! I'll prepare a
> > > patch and a fixup script. And we'll send a last warning before the
> > > final push...
> >
> > Paul's patch already contains the renaming, being the cause of this
> > discussion, I think he deserves the credit :-)
> >
> > http://bugs.orocos.org/show_bug.cgi?id=950#c8
>
> Absolutely, I missed that. But there are a couple other occurences, in
> rttlib, etc. that need fixing, so I'll apply his first and the other
> on top.
I sent you a pull request via gitorious with Paul's patch + some
additional renames + two unrelated and small bugfixes. I propose the
following one-liner to carry out the renaming:
$ find . ! -path "*.git*" -name "*.lua" -print0 | xargs -0 sed -i s/\"deployer\"/\"Deployer\"/g
It will rename all occurences of "deployer" (including double quotes)
to "Deployer" in all .lua files.
Markus
Lua users: please read this
On Sun, Dec 16, 2012 at 9:05 PM, Markus Klotzbuecher
<markus [dot] klotzbuecher [..] ...> wrote:
> On Sat, Dec 15, 2012 at 10:21:15PM +0100, Markus Klotzbuecher wrote:
>> On Sat, Dec 15, 2012 at 09:42:29PM +0100, Peter Soetens wrote:
>> > On Sat, Dec 15, 2012 at 12:56 PM, Markus Klotzbuecher
>> > <markus [dot] klotzbuecher [..] ...> wrote:
>> > > On Fri, Dec 14, 2012 at 10:57:44AM +0100, Peter Soetens wrote:
>> > >> There is a thread going on to change the default name of the
>> > >> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
>> > >> Since component names are case sensitive, this would break about every
>> > >> lua script that contains the lines:
>> > >>
>> > >> tc = rttl.getTC()
>> > >> depl = tc:getPeer("deployer")
>> > >>
>> > >> We could push this to the 2.6.0 branch and document it as a Caveat in
>> > >> the release notes. We could also fabricate a script to fixup your
>> > >> packages.
>> > >>
>> > >> Since Lua deployment is picking up, it's only getting more difficult
>> > >> in the future to make such a change. So here's a chance to formulate
>> > >> your opinion on this (+1/-1).
>> > >
>> > > Thanks to everyone for voting and agreeing to fix this! I'll prepare a
>> > > patch and a fixup script. And we'll send a last warning before the
>> > > final push...
>> >
>> > Paul's patch already contains the renaming, being the cause of this
>> > discussion, I think he deserves the credit :-)
>> >
>> > http://bugs.orocos.org/show_bug.cgi?id=950#c8
>>
>> Absolutely, I missed that. But there are a couple other occurences, in
>> rttlib, etc. that need fixing, so I'll apply his first and the other
>> on top.
>
> I sent you a pull request via gitorious with Paul's patch + some
> additional renames + two unrelated and small bugfixes. I propose the
> following one-liner to carry out the renaming:
>
> $ find . ! -path "*.git*" -name "*.lua" -print0 | xargs -0 sed -i s/\"deployer\"/\"Deployer\"/g
>
> It will rename all occurences of "deployer" (including double quotes)
> to "Deployer" in all .lua files.
I've pushed all this to the toolchain-2.6 branch.
Peter
Lua users: please read this
On Sun, Dec 16, 2012 at 09:29:29PM +0100, Peter Soetens wrote:
> On Sun, Dec 16, 2012 at 9:05 PM, Markus Klotzbuecher
> <markus [dot] klotzbuecher [..] ...> wrote:
> > On Sat, Dec 15, 2012 at 10:21:15PM +0100, Markus Klotzbuecher wrote:
> >> On Sat, Dec 15, 2012 at 09:42:29PM +0100, Peter Soetens wrote:
> >> > On Sat, Dec 15, 2012 at 12:56 PM, Markus Klotzbuecher
> >> > <markus [dot] klotzbuecher [..] ...> wrote:
> >> > > On Fri, Dec 14, 2012 at 10:57:44AM +0100, Peter Soetens wrote:
> >> > >> There is a thread going on to change the default name of the
> >> > >> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> >> > >> Since component names are case sensitive, this would break about every
> >> > >> lua script that contains the lines:
> >> > >>
> >> > >> tc = rttl.getTC()
> >> > >> depl = tc:getPeer("deployer")
> >> > >>
> >> > >> We could push this to the 2.6.0 branch and document it as a Caveat in
> >> > >> the release notes. We could also fabricate a script to fixup your
> >> > >> packages.
> >> > >>
> >> > >> Since Lua deployment is picking up, it's only getting more difficult
> >> > >> in the future to make such a change. So here's a chance to formulate
> >> > >> your opinion on this (+1/-1).
> >> > >
> >> > > Thanks to everyone for voting and agreeing to fix this! I'll prepare a
> >> > > patch and a fixup script. And we'll send a last warning before the
> >> > > final push...
> >> >
> >> > Paul's patch already contains the renaming, being the cause of this
> >> > discussion, I think he deserves the credit :-)
> >> >
> >> > http://bugs.orocos.org/show_bug.cgi?id=950#c8
> >>
> >> Absolutely, I missed that. But there are a couple other occurences, in
> >> rttlib, etc. that need fixing, so I'll apply his first and the other
> >> on top.
> >
> > I sent you a pull request via gitorious with Paul's patch + some
> > additional renames + two unrelated and small bugfixes. I propose the
> > following one-liner to carry out the renaming:
> >
> > $ find . ! -path "*.git*" -name "*.lua" -print0 | xargs -0 sed -i s/\"deployer\"/\"Deployer\"/g
> >
> > It will rename all occurences of "deployer" (including double quotes)
> > to "Deployer" in all .lua files.
>
> I've pushed all this to the toolchain-2.6 branch.
Thanks. I updated the LuaCookbook and added a big warning at the top.
Markus
Lua users: please read this
On 12/16/2012 09:29 PM, Peter Soetens wrote:
> On Sun, Dec 16, 2012 at 9:05 PM, Markus Klotzbuecher
> <markus [dot] klotzbuecher [..] ...> wrote:
>> On Sat, Dec 15, 2012 at 10:21:15PM +0100, Markus Klotzbuecher wrote:
>>> On Sat, Dec 15, 2012 at 09:42:29PM +0100, Peter Soetens wrote:
>>>> On Sat, Dec 15, 2012 at 12:56 PM, Markus Klotzbuecher
>>>> <markus [dot] klotzbuecher [..] ...> wrote:
>>>>> On Fri, Dec 14, 2012 at 10:57:44AM +0100, Peter Soetens wrote:
>>>>>> There is a thread going on to change the default name of the
>>>>>> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
>>>>>> Since component names are case sensitive, this would break about every
>>>>>> lua script that contains the lines:
>>>>>>
>>>>>> tc = rttl.getTC()
>>>>>> depl = tc:getPeer("deployer")
>>>>>>
>>>>>> We could push this to the 2.6.0 branch and document it as a Caveat in
>>>>>> the release notes. We could also fabricate a script to fixup your
>>>>>> packages.
>>>>>>
>>>>>> Since Lua deployment is picking up, it's only getting more difficult
>>>>>> in the future to make such a change. So here's a chance to formulate
>>>>>> your opinion on this (+1/-1).
>>>>>
>>>>> Thanks to everyone for voting and agreeing to fix this! I'll prepare a
>>>>> patch and a fixup script. And we'll send a last warning before the
>>>>> final push...
>>>>
>>>> Paul's patch already contains the renaming, being the cause of this
>>>> discussion, I think he deserves the credit :-)
>>>>
>>>> http://bugs.orocos.org/show_bug.cgi?id=950#c8
>>>
>>> Absolutely, I missed that. But there are a couple other occurences, in
>>> rttlib, etc. that need fixing, so I'll apply his first and the other
>>> on top.
>>
>> I sent you a pull request via gitorious with Paul's patch + some
>> additional renames + two unrelated and small bugfixes. I propose the
>> following one-liner to carry out the renaming:
>>
>> $ find . ! -path "*.git*" -name "*.lua" -print0 | xargs -0 sed -i s/\"deployer\"/\"Deployer\"/g
>>
>> It will rename all occurences of "deployer" (including double quotes)
>> to "Deployer" in all .lua files.
>
> I've pushed all this to the toolchain-2.6 branch.
>
> Peter
>
Thank you everybody.
Peter, you can close Bug 950.
Lua users: please read this
+1
Pozdrawiam
Konrad Banachowicz
2012/12/14 Peter Soetens <peter [..] ...>
> There is a thread going on to change the default name of the
> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> Since component names are case sensitive, this would break about every
> lua script that contains the lines:
>
> tc = rttl.getTC()
> depl = tc:getPeer("deployer")
>
> We could push this to the 2.6.0 branch and document it as a Caveat in
> the release notes. We could also fabricate a script to fixup your
> packages.
>
> Since Lua deployment is picking up, it's only getting more difficult
> in the future to make such a change. So here's a chance to formulate
> your opinion on this (+1/-1).
>
> Peter
> --
> Orocos-Users mailing list
> Orocos-Users [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>
Lua users: please read this
On Dec 14, 2012, at 3:57 AM, Peter Soetens wrote:
> There is a thread going on to change the default name of the
> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> Since component names are case sensitive, this would break about every
> lua script that contains the lines:
>
> tc = rttl.getTC()
> depl = tc:getPeer("deployer")
>
> We could push this to the 2.6.0 branch and document it as a Caveat in
> the release notes. We could also fabricate a script to fixup your
> packages.
>
> Since Lua deployment is picking up, it's only getting more difficult
> in the future to make such a change. So here's a chance to formulate
> your opinion on this (+1/-1).
>
> Peter
Lua users: please read this
+1
2012/12/14 Peter Soetens <peter [..] ...>
> There is a thread going on to change the default name of the
> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> Since component names are case sensitive, this would break about every
> lua script that contains the lines:
>
> tc = rttl.getTC()
> depl = tc:getPeer("deployer")
>
> We could push this to the 2.6.0 branch and document it as a Caveat in
> the release notes. We could also fabricate a script to fixup your
> packages.
>
> Since Lua deployment is picking up, it's only getting more difficult
> in the future to make such a change. So here's a chance to formulate
> your opinion on this (+1/-1).
>
> Peter
> --
> Orocos-Users mailing list
> Orocos-Users [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>
Lua users: please read this
On Fri, Dec 14, 2012 at 10:57 AM, Peter Soetens <peter [..] ...>wrote:
> There is a thread going on to change the default name of the
> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> Since component names are case sensitive, this would break about every
> lua script that contains the lines:
>
> tc = rttl.getTC()
> depl = tc:getPeer("deployer")
>
> We could push this to the 2.6.0 branch and document it as a Caveat in
> the release notes. We could also fabricate a script to fixup your
> packages.
>
> Since Lua deployment is picking up, it's only getting more difficult
> in the future to make such a change. So here's a chance to formulate
> your opinion on this (+1/-1).
>
> Peter
> --
> Orocos-Users mailing list
> Orocos-Users [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>
+1
Lua users: please read this
2012/12/14 Bert Willaert <bert [dot] willaert [..] ...>
>
>
> On Fri, Dec 14, 2012 at 10:57 AM, Peter Soetens <peter [..] ...>wrote:
>
>> There is a thread going on to change the default name of the
>> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
>> Since component names are case sensitive, this would break about every
>> lua script that contains the lines:
>>
>> tc = rttl.getTC()
>> depl = tc:getPeer("deployer")
>>
>> We could push this to the 2.6.0 branch and document it as a Caveat in
>> the release notes. We could also fabricate a script to fixup your
>> packages.
>>
>> Since Lua deployment is picking up, it's only getting more difficult
>> in the future to make such a change. So here's a chance to formulate
>> your opinion on this (+1/-1).
>>
>> Peter
>> --
>> Orocos-Users mailing list
>> Orocos-Users [..] ...
>> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>>
>
> +1
>
>
+1
> --
> Orocos-Users mailing list
> Orocos-Users [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>
>
Lua users: please read this
2012/12/14 Charles Lesire-Cabaniols <charles [dot] lesire [..] ...>:
>
>
>
> 2012/12/14 Bert Willaert <bert [dot] willaert [..] ...>
>>
>>
>>
>> On Fri, Dec 14, 2012 at 10:57 AM, Peter Soetens <peter [..] ...>
>> wrote:
>>>
>>> There is a thread going on to change the default name of the
>>> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
>>> Since component names are case sensitive, this would break about every
>>> lua script that contains the lines:
>>>
>>> tc = rttl.getTC()
>>> depl = tc:getPeer("deployer")
>>>
>>> We could push this to the 2.6.0 branch and document it as a Caveat in
>>> the release notes. We could also fabricate a script to fixup your
>>> packages.
>>>
>>> Since Lua deployment is picking up, it's only getting more difficult
>>> in the future to make such a change. So here's a chance to formulate
>>> your opinion on this (+1/-1).
>>>
>>> Peter
>>> --
>>> Orocos-Users mailing list
>>> Orocos-Users [..] ...
>>> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>>
>>
>> +1
>>
>
> +1
>
>>
>> --
>> Orocos-Users mailing list
>> Orocos-Users [..] ...
>> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>>
>
>
> --
> Orocos-Users mailing list
> Orocos-Users [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-users
>
+1
I'll take the time to make changes
Lua users: please read this
> There is a thread going on to change the default name of the
> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> Since component names are case sensitive, this would break about every
> lua script that contains the lines:
>
> tc = rttl.getTC()
> depl = tc:getPeer("deployer")
>
> We could push this to the 2.6.0 branch and document it as a Caveat in
> the release notes. We could also fabricate a script to fixup your
> packages.
>
> Since Lua deployment is picking up, it's only getting more difficult
> in the future to make such a change. So here's a chance to formulate
> your opinion on this (+1/-1).
+1
Note: Do this actually suggest to name (or rename) all components instances
with a capital letter at the beginning, as convention/best practice?
- Enea
Lua users: please read this
On 12/14/2012 10:57 AM, Peter Soetens wrote:
> There is a thread going on to change the default name of the
> DeploymentComponent of 'rttlua' into 'Deployer' instead of 'deployer'.
> Since component names are case sensitive, this would break about every
> lua script that contains the lines:
>
> tc = rttl.getTC()
> depl = tc:getPeer("deployer")
>
> We could push this to the 2.6.0 branch and document it as a Caveat in
> the release notes. We could also fabricate a script to fixup your
> packages.
>
> Since Lua deployment is picking up, it's only getting more difficult
> in the future to make such a change. So here's a chance to formulate
> your opinion on this (+1/-1).
+1
it will brake a lot of my stuff, but it is more consistent and will make my life easier in the long run!
>
> Peter
>
nick