[Bug 717] New: Don't try to build corba test if corba is not enabled

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=717

Summary: Don't try to build corba test if corba is not enabled
Product: RTT
Version: 1.10.1
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P3
Component: Build System
AssignedTo: orocos-dev [..] ...
ReportedBy: klaas [dot] gadeyne [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

WORKSFORME...

kgad@ampere /kgad/workspaces/orocos/rtt-1.10]$
svn diff
Index: tests/CMakeLists.txt
===================================================================
--- tests/CMakeLists.txt (revision 30840)
+++ tests/CMakeLists.txt (working copy)
@@ -42,7 +42,9 @@
LINK_FLAGS "${CMAKE_LD_FLAGS_ADD}"
COMPILE_DEFINITIONS "${OROCOS-RTT_DEFINITIONS}" )
ADD_TEST( list-test ${CMAKE_CURRENT_BINARY_DIR}/list-test )
+ IF(ENABLE_CORBA)
list(APPEND ORO_EXTRA_TESTS "corba-test")
+ ENDIF(ENABLE_CORBA)
endif()

# repeat for each test

[Bug 717] Don't try to build corba test if corba is not enabled

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=717

Peter Soetens <peter [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution| |FIXED
Status|NEW |RESOLVED

--- Comment #2 from Peter Soetens <peter [..] ...> 2009-10-27 11:36:37 ---
(In reply to comment #0)
> WORKSFORME...
>
> kgad@ampere /kgad/workspaces/orocos/rtt-1.10]$
> svn diff
> Index: tests/CMakeLists.txt
> ===================================================================
> --- tests/CMakeLists.txt (revision 30840)
> +++ tests/CMakeLists.txt (working copy)
> @@ -42,7 +42,9 @@
> LINK_FLAGS "${CMAKE_LD_FLAGS_ADD}"
> COMPILE_DEFINITIONS "${OROCOS-RTT_DEFINITIONS}" )
> ADD_TEST( list-test ${CMAKE_CURRENT_BINARY_DIR}/list-test )
> + IF(ENABLE_CORBA)
> list(APPEND ORO_EXTRA_TESTS "corba-test")
> + ENDIF(ENABLE_CORBA)
> endif()
>
> # repeat for each test

Properly fixed on rtt-1.10 branch.

Peter

[Bug 717] Don't try to build corba test if corba is not enabled

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=717

Peter Soetens <peter [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |peter [..] ...

--- Comment #1 from Peter Soetens <peter [..] ...> 2009-10-26 14:07:51 ---
(In reply to comment #0)
> WORKSFORME...
>
> kgad@ampere /kgad/workspaces/orocos/rtt-1.10]$
> svn diff
> Index: tests/CMakeLists.txt
> ===================================================================
> --- tests/CMakeLists.txt (revision 30840)
> +++ tests/CMakeLists.txt (working copy)
> @@ -42,7 +42,9 @@
> LINK_FLAGS "${CMAKE_LD_FLAGS_ADD}"
> COMPILE_DEFINITIONS "${OROCOS-RTT_DEFINITIONS}" )
> ADD_TEST( list-test ${CMAKE_CURRENT_BINARY_DIR}/list-test )
> + IF(ENABLE_CORBA)
> list(APPEND ORO_EXTRA_TESTS "corba-test")
> + ENDIF(ENABLE_CORBA)
> endif()
>
> # repeat for each test

The fix is wrong. The real bug is a copy/paste error. The line should have
read:

list(APPEND ORO_EXTRA_TESTS "list-test")

Peter