[Bug 721] Destroying running function seg-faults ProgramProcessor later

On Nov 2, 2009, at 07:57 , Peter Soetens wrote:

> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=721
>
>
>
>
>
> --- Comment #6 from Peter Soetens <peter [..] ...>
> 2009-11-02 13:57:37 ---
> Created an attachment (id=542)
> --> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=542)
> Drops useless triggering and clear PP from function
>
> The previous patch was wrong. The trigger is useless, since our
> function is
> already cleared. What needs to be done is to remove the
> ProgramProcessor from
> the function, such that the function's owner can see it's no longer
> loaded.
>
> Replaces previous patch.
>
> Peter

What branch/repo was that patch applied on? Neither SVN trunk nor git/
v1 appear to match. And neither has the mutex lock in it, AFAICS.

Stephen

[Bug 721] Destroying running function seg-faults ProgramProcesso

On Mon, Nov 2, 2009 at 14:01, S Roderick <kiwi [dot] net [..] ...> wrote:
> On Nov 2, 2009, at 07:57 , Peter Soetens wrote:
>
>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=721
>>
>>
>>
>>
>>
>> --- Comment #6 from Peter Soetens <peter [..] ...>  2009-11-02
>> 13:57:37 ---
>> Created an attachment (id=542)
>> --> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=542)
>> Drops useless triggering and clear PP from function
>>
>> The previous patch was wrong. The trigger is useless, since our function
>> is
>> already cleared. What needs to be done is to remove the ProgramProcessor
>> from
>> the function, such that the function's owner can see it's no longer
>> loaded.
>>
>> Replaces previous patch.
>>
>> Peter
>
> What branch/repo was that patch applied on? Neither SVN trunk nor git/v1
> appear to match. And neither has the mutex lock in it, AFAICS.

You need to add it in addition to the first patch you tested. There
were three patches attached to this bug, you need (1) and (3).

Peter

[Bug 721] Destroying running function seg-faults ProgramProcesso

On Nov 2, 2009, at 09:48 , Peter Soetens wrote:

> On Mon, Nov 2, 2009 at 14:01, S Roderick <kiwi [dot] net [..] ...> wrote:
>> On Nov 2, 2009, at 07:57 , Peter Soetens wrote:
>>
>>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=721
>>>
>>>
>>>
>>>
>>>
>>> --- Comment #6 from Peter Soetens <peter [..] ...>
>>> 2009-11-02
>>> 13:57:37 ---
>>> Created an attachment (id=542)
>>> --> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=542)
>>> Drops useless triggering and clear PP from function
>>>
>>> The previous patch was wrong. The trigger is useless, since our
>>> function
>>> is
>>> already cleared. What needs to be done is to remove the
>>> ProgramProcessor
>>> from
>>> the function, such that the function's owner can see it's no longer
>>> loaded.
>>>
>>> Replaces previous patch.
>>>
>>> Peter
>>
>> What branch/repo was that patch applied on? Neither SVN trunk nor
>> git/v1
>> appear to match. And neither has the mutex lock in it, AFAICS.
>
> You need to add it in addition to the first patch you tested. There
> were three patches attached to this bug, you need (1) and (3).

Confirm that patch fixes our issue. Tested on Hardy and Snow Leopard.

Cheers!
Stephen