http://bugs.orocos.org/show_bug.cgi?id=854
Summary: Typegen generated transports does not compile due to
TYPEKIT_REGISTRY not being a string
Product: Toolchain
Version: 2.3.0
Platform: All
OS/Version: All
Status: NEW
Severity: critical
Priority: P3
Component: orogen
AssignedTo: orocos-dev [..] ...
ReportedBy: charles [dot] lesire [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0
Created attachment 677
--> http://bugs.orocos.org/attachment.cgi?id=677
Patch
When compiling a typekit using typegen and the Orocos macros, the following
error is encountered:
/home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:
In constructor
‘orogen_typekits::FooTypelibTransportPlugin::FooTypelibTransportPlugin()’:
/home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:39:
error: invalid conversion from ‘int’ to ‘const char*’
/home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:39:
error: initializing argument 1 of ‘std::basic_string<_CharT, _Traits,
_Alloc>::basic_string(const _CharT*, const _Alloc&) [with _CharT = char,
_Traits = std::char_traits<char>, _Alloc = std::allocator<char>]’
It comes from TYPEKIT_REGISTRY being considered as an int. In the compilation
command, it is defined as
-DTYPEKIT_REGISTRY="'\"/home/lesire/work/robotis-pkg/install/share/orogen/Foo.tlb\"'"
that seems to have too many quotes.
Patch attached that modifies the CMakeList template in orogen.
Charles.
--
Configure bugmail: http://bugs.orocos.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
--
Orocos-Dev mailing list
Orocos-Dev [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
[Bug 854] Typegen generated transports does not compile due to T
http://bugs.orocos.org/show_bug.cgi?id=854
Peter Soetens <peter [..] ...> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #4 from Peter Soetens <peter [..] ...> 2011-04-22 10:34:21 CEST ---
Fixed this on master/toolchain-2.3 branches.
The difference in results was because of including or not including the ros
cmake macros, which require cmake 2.4 behavior, which differs from cmake 2.6
behavior regarding add_definitions()
Peter
[Bug 854] Typegen generated transports does not compile due to T
http://bugs.orocos.org/show_bug.cgi?id=854
Peter Soetens <peter [..] ...> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #677 is|0 |1
obsolete| |
--- Comment #3 from Peter Soetens <peter [..] ...> 2011-04-22 10:32:25 CEST ---
Created attachment 679
--> http://bugs.orocos.org/attachment.cgi?id=679
Proper cmake fix for this bug
See http://www.cmake.org/Wiki/CMake/Policies for the
add_definitions() problem this code produces.
[Bug 854] Typegen generated transports does not compile due to T
http://bugs.orocos.org/show_bug.cgi?id=854
--- Comment #2 from Peter Soetens <peter [..] ...> 2011-04-13 11:43:14 CEST ---
When applying your patch, we get:
-DTYPEKIT_REGISTRY="/usr/local/share/orogen/typekit.tlb"
in the compilation command, while the desired form is:
-DTYPEKIT_REGISTRY='"/usr/local/share/orogen/typekit.tlb"'
I tried to reproduce your case with cmake 2.6.4, 2.8.0, 2.8.1 2.8.2 and 2.8.4
and none add these extra '\' in the compilation command. None work with your
patch applied.
Could you download cmake 2.8.2, compile it and generate the build dir with that
version ?
Peter
[Bug 854] Typegen generated transports does not compile due to T
On 13/04/2011 11:43, Peter Soetens wrote:
> http://bugs.orocos.org/show_bug.cgi?id=854
>
> --- Comment #2 from Peter Soetens<peter [..] ...> 2011-04-13 11:43:14 CEST ---
> When applying your patch, we get:
>
> -DTYPEKIT_REGISTRY="/usr/local/share/orogen/typekit.tlb"
>
> in the compilation command, while the desired form is:
>
>
> -DTYPEKIT_REGISTRY='"/usr/local/share/orogen/typekit.tlb"'
>
> I tried to reproduce your case with cmake 2.6.4, 2.8.0, 2.8.1 2.8.2 and 2.8.4
> and none add these extra '\' in the compilation command. None work with your
> patch applied.
>
> Could you download cmake 2.8.2, compile it and generate the build dir with that
> version ?
>
> Peter
>
The cmake version I use is 2.8.2 from the cmake packet available on
Ubuntu 10.10 (whose version is 2.8.2-2ubuntu0.1).
Do you really think I should compile cmake from sources?
Charles.
[Bug 854] Typegen generated transports does not compile due to T
On Wednesday 13 April 2011 13:18:58 Charles Lesire-Cabaniols wrote:
> On 13/04/2011 11:43, Peter Soetens wrote:
> > http://bugs.orocos.org/show_bug.cgi?id=854
> >
> > --- Comment #2 from Peter Soetens<peter [..] ...> 2011-04-13
> > 11:43:14 CEST --- When applying your patch, we get:
> >
> > -DTYPEKIT_REGISTRY="/usr/local/share/orogen/typekit.tlb"
> >
> > in the compilation command, while the desired form is:
> >
> >
> > -DTYPEKIT_REGISTRY='"/usr/local/share/orogen/typekit.tlb"'
> >
> > I tried to reproduce your case with cmake 2.6.4, 2.8.0, 2.8.1 2.8.2 and
> > 2.8.4 and none add these extra '\' in the compilation command. None work
> > with your patch applied.
> >
> > Could you download cmake 2.8.2, compile it and generate the build dir
> > with that version ?
> >
> > Peter
>
> The cmake version I use is 2.8.2 from the cmake packet available on
> Ubuntu 10.10 (whose version is 2.8.2-2ubuntu0.1).
>
> Do you really think I should compile cmake from sources?
Only for testing purposes, to see if Ubuntu cmake is different from standard
cmake with respect to this quoting issue.
I've unpacked cmake 2.8.2 in my /tmp dir and ran /tmp/cmake-2.8.2/bin/cmake ..
in the build directory of the generated typekit.
Peter
[Bug 854] Typegen generated transports does not compile due to T
On 13/04/2011 16:16, Peter Soetens wrote:
> On Wednesday 13 April 2011 13:18:58 Charles Lesire-Cabaniols wrote:
>> On 13/04/2011 11:43, Peter Soetens wrote:
>>> http://bugs.orocos.org/show_bug.cgi?id=854
>>>
>>> --- Comment #2 from Peter Soetens<peter [..] ...> 2011-04-13
>>> 11:43:14 CEST --- When applying your patch, we get:
>>>
>>> -DTYPEKIT_REGISTRY="/usr/local/share/orogen/typekit.tlb"
>>>
>>> in the compilation command, while the desired form is:
>>>
>>>
>>> -DTYPEKIT_REGISTRY='"/usr/local/share/orogen/typekit.tlb"'
>>>
>>> I tried to reproduce your case with cmake 2.6.4, 2.8.0, 2.8.1 2.8.2 and
>>> 2.8.4 and none add these extra '\' in the compilation command. None work
>>> with your patch applied.
>>>
>>> Could you download cmake 2.8.2, compile it and generate the build dir
>>> with that version ?
>>>
>>> Peter
>> The cmake version I use is 2.8.2 from the cmake packet available on
>> Ubuntu 10.10 (whose version is 2.8.2-2ubuntu0.1).
>>
>> Do you really think I should compile cmake from sources?
> Only for testing purposes, to see if Ubuntu cmake is different from standard
> cmake with respect to this quoting issue.
>
> I've unpacked cmake 2.8.2 in my /tmp dir and ran /tmp/cmake-2.8.2/bin/cmake ..
> in the build directory of the generated typekit.
>
> Peter
I have the same result with cmake 2.8.2 built from sources:
- with the patch:
-DTYPEKIT_REGISTRY=\"/home/lesire/work/robotis-pkg/install/share/orogen/CICAS.tlb\"
- without the patch:
-DTYPEKIT_REGISTRY="'\"/home/lesire/work/robotis-pkg/install/share/orogen/CICAS.tlb\"'"
Charles.
[Bug 854] Typegen generated transports does not compile due to T
On Thu, Apr 14, 2011 at 9:44 AM, Charles Lesire-Cabaniols
<Charles [dot] Lesire [..] ...> wrote:
> On 13/04/2011 16:16, Peter Soetens wrote:
>>
>> On Wednesday 13 April 2011 13:18:58 Charles Lesire-Cabaniols wrote:
>>>
>>> On 13/04/2011 11:43, Peter Soetens wrote:
>>>>
>>>> http://bugs.orocos.org/show_bug.cgi?id=854
>>>>
>>>> --- Comment #2 from Peter Soetens<peter [..] ...> 2011-04-13
>>>> 11:43:14 CEST --- When applying your patch, we get:
>>>>
>>>> -DTYPEKIT_REGISTRY="/usr/local/share/orogen/typekit.tlb"
>>>>
>>>> in the compilation command, while the desired form is:
>>>>
>>>>
>>>> -DTYPEKIT_REGISTRY='"/usr/local/share/orogen/typekit.tlb"'
>>>>
>>>> I tried to reproduce your case with cmake 2.6.4, 2.8.0, 2.8.1 2.8.2 and
>>>> 2.8.4 and none add these extra '\' in the compilation command. None work
>>>> with your patch applied.
>>>>
>>>> Could you download cmake 2.8.2, compile it and generate the build dir
>>>> with that version ?
>>>>
>>>> Peter
>>>
>>> The cmake version I use is 2.8.2 from the cmake packet available on
>>> Ubuntu 10.10 (whose version is 2.8.2-2ubuntu0.1).
>>>
>>> Do you really think I should compile cmake from sources?
>>
>> Only for testing purposes, to see if Ubuntu cmake is different from
>> standard
>> cmake with respect to this quoting issue.
>>
>> I've unpacked cmake 2.8.2 in my /tmp dir and ran
>> /tmp/cmake-2.8.2/bin/cmake ..
>> in the build directory of the generated typekit.
>>
>> Peter
>
> I have the same result with cmake 2.8.2 built from sources:
> - with the patch:
> -DTYPEKIT_REGISTRY=\"/home/lesire/work/robotis-pkg/install/share/orogen/CICAS.tlb\"
> - without the patch:
> -DTYPEKIT_REGISTRY="'\"/home/lesire/work/robotis-pkg/install/share/orogen/CICAS.tlb\"'"
That's strange ! My -D statement does not contain the back-slashes
before the " sign. In neither case. Can you figure out how these came
there ? It looks like it's not a cmake issue (since we have the same
version), but that something else is adding them. We should probably
start to compare the generated Makefiles and see how these differ.
Can other Ubuntu 10.10 users confirm this ? Who's the exception,
Charles or my side ?
Peter
--
Orocos-Dev mailing list
Orocos-Dev [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
[Bug 854] Typegen generated transports does not compile due to T
On 14/04/2011 10:07, Peter Soetens wrote:
> On Thu, Apr 14, 2011 at 9:44 AM, Charles Lesire-Cabaniols
> <Charles [dot] Lesire [..] ...> wrote:
>> On 13/04/2011 16:16, Peter Soetens wrote:
>>> On Wednesday 13 April 2011 13:18:58 Charles Lesire-Cabaniols wrote:
>>>> On 13/04/2011 11:43, Peter Soetens wrote:
>>>>> http://bugs.orocos.org/show_bug.cgi?id=854
>>>>>
>>>>> --- Comment #2 from Peter Soetens<peter [..] ...> 2011-04-13
>>>>> 11:43:14 CEST --- When applying your patch, we get:
>>>>>
>>>>> -DTYPEKIT_REGISTRY="/usr/local/share/orogen/typekit.tlb"
>>>>>
>>>>> in the compilation command, while the desired form is:
>>>>>
>>>>>
>>>>> -DTYPEKIT_REGISTRY='"/usr/local/share/orogen/typekit.tlb"'
>>>>>
>>>>> I tried to reproduce your case with cmake 2.6.4, 2.8.0, 2.8.1 2.8.2 and
>>>>> 2.8.4 and none add these extra '\' in the compilation command. None work
>>>>> with your patch applied.
>>>>>
>>>>> Could you download cmake 2.8.2, compile it and generate the build dir
>>>>> with that version ?
>>>>>
>>>>> Peter
>>>> The cmake version I use is 2.8.2 from the cmake packet available on
>>>> Ubuntu 10.10 (whose version is 2.8.2-2ubuntu0.1).
>>>>
>>>> Do you really think I should compile cmake from sources?
>>> Only for testing purposes, to see if Ubuntu cmake is different from
>>> standard
>>> cmake with respect to this quoting issue.
>>>
>>> I've unpacked cmake 2.8.2 in my /tmp dir and ran
>>> /tmp/cmake-2.8.2/bin/cmake ..
>>> in the build directory of the generated typekit.
>>>
>>> Peter
>> I have the same result with cmake 2.8.2 built from sources:
>> - with the patch:
>> -DTYPEKIT_REGISTRY=\"/home/lesire/work/robotis-pkg/install/share/orogen/CICAS.tlb\"
>> - without the patch:
>> -DTYPEKIT_REGISTRY="'\"/home/lesire/work/robotis-pkg/install/share/orogen/CICAS.tlb\"'"
> That's strange ! My -D statement does not contain the back-slashes
> before the " sign. In neither case. Can you figure out how these came
> there ? It looks like it's not a cmake issue (since we have the same
> version), but that something else is adding them. We should probably
> start to compare the generated Makefiles and see how these differ.
>
> Can other Ubuntu 10.10 users confirm this ? Who's the exception,
> Charles or my side ?
>
> Peter
One of my students is facing the same behaviour on Ubuntu 10.04.2 LTS
with cmake 2.8.0
$ gcc -v :
Using built-in specs.
Target: i486-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu
4.4.3-4ubuntu5' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs
--enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr
--enable-shared --enable-multiarch --enable-linker-build-id
--with-system-zlib --libexecdir=/usr/lib --without-included-gettext
--enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.4
--program-suffix=-4.4 --enable-nls --enable-clocale=gnu
--enable-libstdcxx-debug --enable-plugin --enable-objc-gc
--enable-targets=all --disable-werror --with-arch-32=i486
--with-tune=generic --enable-checking=release --build=i486-linux-gnu
--host=i486-linux-gnu --target=i486-linux-gnu
Thread model: posix
gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5)
$ cmake --version :
cmake version 2.8.0
$ uname -a :
Linux wdcsd003h 2.6.32-30-generic-pae #59-Ubuntu SMP Tue Mar 1 23:01:33
UTC 2011 i686 GNU/Linux
Charles.
[Bug 854] Typegen generated transports does not compile due to T
On 14/04/2011 10:07, Peter Soetens wrote:
> On Thu, Apr 14, 2011 at 9:44 AM, Charles Lesire-Cabaniols
> <Charles [dot] Lesire [..] ...> wrote:
>> On 13/04/2011 16:16, Peter Soetens wrote:
>>> On Wednesday 13 April 2011 13:18:58 Charles Lesire-Cabaniols wrote:
>>>> On 13/04/2011 11:43, Peter Soetens wrote:
>>>>> http://bugs.orocos.org/show_bug.cgi?id=854
>>>>>
>>>>> --- Comment #2 from Peter Soetens<peter [..] ...> 2011-04-13
>>>>> 11:43:14 CEST --- When applying your patch, we get:
>>>>>
>>>>> -DTYPEKIT_REGISTRY="/usr/local/share/orogen/typekit.tlb"
>>>>>
>>>>> in the compilation command, while the desired form is:
>>>>>
>>>>>
>>>>> -DTYPEKIT_REGISTRY='"/usr/local/share/orogen/typekit.tlb"'
>>>>>
>>>>> I tried to reproduce your case with cmake 2.6.4, 2.8.0, 2.8.1 2.8.2 and
>>>>> 2.8.4 and none add these extra '\' in the compilation command. None work
>>>>> with your patch applied.
>>>>>
>>>>> Could you download cmake 2.8.2, compile it and generate the build dir
>>>>> with that version ?
>>>>>
>>>>> Peter
>>>> The cmake version I use is 2.8.2 from the cmake packet available on
>>>> Ubuntu 10.10 (whose version is 2.8.2-2ubuntu0.1).
>>>>
>>>> Do you really think I should compile cmake from sources?
>>> Only for testing purposes, to see if Ubuntu cmake is different from
>>> standard
>>> cmake with respect to this quoting issue.
>>>
>>> I've unpacked cmake 2.8.2 in my /tmp dir and ran
>>> /tmp/cmake-2.8.2/bin/cmake ..
>>> in the build directory of the generated typekit.
>>>
>>> Peter
>> I have the same result with cmake 2.8.2 built from sources:
>> - with the patch:
>> -DTYPEKIT_REGISTRY=\"/home/lesire/work/robotis-pkg/install/share/orogen/CICAS.tlb\"
>> - without the patch:
>> -DTYPEKIT_REGISTRY="'\"/home/lesire/work/robotis-pkg/install/share/orogen/CICAS.tlb\"'"
> That's strange ! My -D statement does not contain the back-slashes
> before the " sign. In neither case. Can you figure out how these came
> there ? It looks like it's not a cmake issue (since we have the same
> version), but that something else is adding them. We should probably
> start to compare the generated Makefiles and see how these differ.
>
> Can other Ubuntu 10.10 users confirm this ? Who's the exception,
> Charles or my side ?
>
> Peter
If that can help:
$ gcc -v
Using built-in specs.
Target: i686-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro
4.4.4-14ubuntu5' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs
--enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr
--program-suffix=-4.4 --enable-shared --enable-multiarch
--enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib
--without-included-gettext --enable-threads=posix
--with-gxx-include-dir=/usr/include/c++/4.4 --libdir=/usr/lib
--enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-objc-gc --enable-targets=all
--disable-werror --with-arch-32=i686 --with-tune=generic
--enable-checking=release --build=i686-linux-gnu --host=i686-linux-gnu
--target=i686-linux-gnu
Thread model: posix
gcc version 4.4.5 (Ubuntu/Linaro 4.4.4-14ubuntu5)
$ uname -a
Linux ecoule 2.6.35-28-generic #50-Ubuntu SMP Fri Mar 18 19:00:26 UTC
2011 i686 GNU/Linux
Charles.
[Bug 854] Typegen generated transports does not compile due to T
On 13/04/2011 11:43, Peter Soetens wrote:
> http://bugs.orocos.org/show_bug.cgi?id=854
>
> --- Comment #2 from Peter Soetens<peter [..] ...> 2011-04-13 11:43:14 CEST ---
> When applying your patch, we get:
>
> -DTYPEKIT_REGISTRY="/usr/local/share/orogen/typekit.tlb"
>
> in the compilation command, while the desired form is:
>
>
> -DTYPEKIT_REGISTRY='"/usr/local/share/orogen/typekit.tlb"'
>
> I tried to reproduce your case with cmake 2.6.4, 2.8.0, 2.8.1 2.8.2 and 2.8.4
> and none add these extra '\' in the compilation command. None work with your
> patch applied.
>
> Could you download cmake 2.8.2, compile it and generate the build dir with that
> version ?
>
> Peter
>
[Bug 854] Typegen generated transports does not compile due to T
http://bugs.orocos.org/show_bug.cgi?id=854
Peter Soetens <peter [..] ...> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |peter [..] ...
--- Comment #1 from Peter Soetens <peter [..] ...> 2011-04-13 10:35:38 CEST ---
(In reply to comment #0)
> Created attachment 677 [details]
> Patch
>
> When compiling a typekit using typegen and the Orocos macros, the following
> error is encountered:
>
> /home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:
> In constructor
> ‘orogen_typekits::FooTypelibTransportPlugin::FooTypelibTransportPlugin()’:
> /home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:39:
> error: invalid conversion from ‘int’ to ‘const char*’
> /home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:39:
> error: initializing argument 1 of ‘std::basic_string<_CharT, _Traits,
> _Alloc>::basic_string(const _CharT*, const _Alloc&) [with _CharT = char,
> _Traits = std::char_traits<char>, _Alloc = std::allocator<char>]’
>
> It comes from TYPEKIT_REGISTRY being considered as an int. In the compilation
> command, it is defined as
> -DTYPEKIT_REGISTRY="'\"/home/lesire/work/robotis-pkg/install/share/orogen/Foo.tlb\"'"
> that seems to have too many quotes.
>
> Patch attached that modifies the CMakeList template in orogen.
>
> Charles.
We have a big issue here. Your patch undoes a recent patch that added these
quotes. Which CMake version are you using ?
Peter
--
Configure bugmail: http://bugs.orocos.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
--
Orocos-Dev mailing list
Orocos-Dev [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
[Bug 854] Typegen generated transports does not compile due to T
On 13/04/2011 10:35, Peter Soetens wrote:
> http://bugs.orocos.org/show_bug.cgi?id=854
>
> Peter Soetens<peter [..] ...> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Status|NEW |ASSIGNED
> CC| |peter [..] ...
>
> --- Comment #1 from Peter Soetens<peter [..] ...> 2011-04-13 10:35:38 CEST ---
> (In reply to comment #0)
>> Created attachment 677 [details]
>> Patch
>>
>> When compiling a typekit using typegen and the Orocos macros, the following
>> error is encountered:
>>
>> /home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:
>> In constructor
>> ‘orogen_typekits::FooTypelibTransportPlugin::FooTypelibTransportPlugin()’:
>> /home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:39:
>> error: invalid conversion from ‘int’ to ‘const char*’
>> /home/lesire/work/sandbox/orocos/Foo/typekit/transports/typelib/TransportPlugin.cpp:39:
>> error: initializing argument 1 of ‘std::basic_string<_CharT, _Traits,
>> _Alloc>::basic_string(const _CharT*, const _Alloc&) [with _CharT = char,
>> _Traits = std::char_traits<char>, _Alloc = std::allocator<char>]’
>>
>> It comes from TYPEKIT_REGISTRY being considered as an int. In the compilation
>> command, it is defined as
>> -DTYPEKIT_REGISTRY="'\"/home/lesire/work/robotis-pkg/install/share/orogen/Foo.tlb\"'"
>> that seems to have too many quotes.
>>
>> Patch attached that modifies the CMakeList template in orogen.
>>
>> Charles.
> We have a big issue here. Your patch undoes a recent patch that added these
> quotes. Which CMake version are you using ?
>
> Peter
>
2.8.2
--
Orocos-Dev mailing list
Orocos-Dev [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev