http://bugs.orocos.org/show_bug.cgi?id=863

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

http://bugs.orocos.org/show_bug.cgi?id=863

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #692 is|0 |1
obsolete| |

--- Comment #3 from Ruben Smits <ruben [dot] smits [..] ...> 2011-05-26 14:04:11 CEST ---
Comment on attachment 692
--> http://bugs.orocos.org/attachment.cgi?id=692
patch to fix the issue

The patch breaks the constructors of the types. As such I have to refuse this
patch.

http://bugs.orocos.org/show_bug.cgi?id=863

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |ruben [dot] smits [..] ...en.b
| |e

--- Comment #2 from Ruben Smits <ruben [dot] smits [..] ...> 2011-05-26 12:31:21 CEST ---
The patch in attachment 692 is applied but I would like to fill in the
operation and argument documentation before I close this bug.

Secondly would it make more sense to add the operations as follows:?

gs->provides("KDL")->provides("Vector")->addOperation("diff",(Vector (*) (const
Vector&, const Vector&, double)) &diff).doc("");
gs->provides("KDL")->provides("Rotation")->addOperation("diff",(Vector (*)
(const Rotation&, const Rotation&, double)) &diff).doc("");
gs->provides("KDL")->provides("Twist")->addOperation("diff",(Twist (*) (const
Twist&, const Twist&, double)) &diff).doc("");
gs->provides("KDL")->provides("Wrench")->->addOperation("diff",(Wrench (*)
(const Wrench&, const Wrench&, double)) &diff).doc("");
gs->provides("KDL")->provides("Frame")->addOperation("diff",(Twist (*) (const
Frame&, const Frame&, double)) &diff)

This would change the scripting syntax from

var double d = KDL.Vector_diff(v1,v2,1.0)
var Vector v3 = KDL.Rotation_diff(R1,R2,1.0)

to

var double d = KDL.Vector.diff(v1,v2,1.0)
var Vector v3 = KDL.Rotation.diff(R1,R2,1.0)

-- Ruben

http://bugs.orocos.org/show_bug.cgi?id=863

--- Comment #1 from Markus Klotzbuecher <markus [dot] klotzbuecher [..] ...> 2011-05-26 09:13:05 CEST ---
Created attachment 692
--> http://bugs.orocos.org/attachment.cgi?id=692
patch to fix the issue