Hi Paul,

On Fri, Apr 27, 2012 at 12:07:49PM +0000, Chavent Paul wrote:
>
> http://bugs.orocos.org/show_bug.cgi?id=950
>
> Chavent Paul <paul [dot] chavent [..] ...> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Attachment #795 is|0 |1
> obsolete| |
>

Hi Paul,

Thanks for the patch. I just discussed with Peter and we agreed that
in the long run the -corba tools should disappear and instead you only
load the corba deployer (from the basic deployer) and configure the
parameters using properties. But this will take some time, so I can
apply your patch.

Just one minor issue below:

[...]

+#if defined(LUA_RTT_CORBA)
+ int orb_argc = argc;
+ char** orb_argv = 0;
+
+ while(orb_argc) {
+ if(0 == strcmp("--", argv[argc - orb_argc])) {
+ argv[argc - orb_argc] = argv[0];
+ orb_argv = &argv[argc - orb_argc];
+ argc -= orb_argc;
+ break;
+ }
+ orb_argc--;
+ }
+
+ if(orb_argc) {
+ try {
+ TaskContextServer::InitOrb(orb_argc, orb_argv);
+
+ dc = new CorbaDeploymentComponent("deployer");
+
+ TaskContextServer::Create( dc, true, true );
+
+ // The orb thread accepts incomming CORBA calls.
+ TaskContextServer::ThreadOrb();
+ }
+ catch( CORBA::Exception &e ) {
+ log(Error) << argv[0] <<" ORO_main : CORBA exception raised!" << Logger::nl;
+ log() << CORBA_EXCEPTION_INFO(e) << endlog();
+ } catch (...) {
+ log(Error) << "Uncaught exception." << endlog();
+ }
+
+ // lua_repl doesn't use argc ?
+ argv[argc] = NULL;

Lua repl _does_ use the arguments, which is very useful to write
standalone scripts (#!/bin/env rttlua) taking arguments. For example:

test.lua:
<lua>
require "utils"
print(utils.tab2str(arg))
<lua>

$ rttlua-gnulinux test.lua --foo --bar 33
{"--foo","--bar","33",[-1]="rttlua-gnulinux",[0]="test.lua"}

Does this still work?
Markus