Feedback on a06d9eaf on dfki-rtt

Submitted by peter on Mon, 2010-11-15 15:12

This patch:

commit a06d9eaf33545c5888f9a8848bc88baf01b88f9e
Author: Sylvain Joyeux <sylvain.joyeux@m4x.org>
Date:   Fri Nov 12 23:25:29 2010 +0100
 
    core: define TaskContext::getProperty<T>
 
diff --git a/rtt/TaskContext.hpp b/rtt/TaskContext.hpp
index b1f53b2..871ee94 100644
--- a/rtt/TaskContext.hpp
+++ b/rtt/TaskContext.hpp
@@ -479,6 +479,19 @@ namespace RTT
         }
 
         /**
+         * Get a Property with name \a name.
+         *
+         * @param  name The name of the property to search for.
+         * @return The Property with this name, zero
+         *         if it does not exist
+         */
+        template<typename T>
+        Property<T>* getProperty(const std::string& name) const
+        {
+            return dynamic_cast<Property<T>*>(tcservice->getProperty(name));
+        }
+
+        /**
          * Returns the properties of this TaskContext as a PropertyBag.
          */
         PropertyBag* properties() { return this->provides()->properties(); }

Can't be accepted because getProperty() may not take a template parameter by
2.x naming conventions (see also: getPort() and getOperation() ).
The correct use of getProperty is:

Property<Foo> f = task->getProperty("foo");
if (f.ready() ) {...}

There is a function 'getPropertyType<T>' in the ConfigurationInterface which
does take a template parameter. Using that function should however not be
needed given the above usage pattern.

Peter

‹ orogen status ? Strange CORBA behaviors with Orocos RTT 2 ›
»
Ruben Smits's picture

Feedback on a06d9eaf on dfki-rtt

Submitted by Ruben Smits on Tue, 2010-11-16 13:08.

On Monday 15 November 2010 16:07:08 Peter Soetens wrote:
> This patch:
>
> 

> commit a06d9eaf33545c5888f9a8848bc88baf01b88f9e
> Author: Sylvain Joyeux <sylvain.joyeux@m4x.org>
> Date:   Fri Nov 12 23:25:29 2010 +0100
> 
>     core: define TaskContext::getProperty<T>
> 
> diff --git a/rtt/TaskContext.hpp b/rtt/TaskContext.hpp
> index b1f53b2..871ee94 100644
> --- a/rtt/TaskContext.hpp
> +++ b/rtt/TaskContext.hpp
> @@ -479,6 +479,19 @@ namespace RTT
>          }
> 
>          /**
> +         * Get a Property with name \a name.
> +         *
> +         * @param  name The name of the property to search for.
> +         * @return The Property with this name, zero
> +         *         if it does not exist
> +         */
> +        template<typename T>
> +        Property<T>* getProperty(const std::string& name) const
> +        {
> +            return
> dynamic_cast<Property<T>*>(tcservice->getProperty(name)); +        }
> +
> +        /**
>           * Returns the properties of this TaskContext as a PropertyBag.
>           */
>          PropertyBag* properties() { return this->provides()->properties();
> }

>
> Can't be accepted because getProperty() may not take a template parameter
> by 2.x naming conventions (see also: getPort() and getOperation() ).
> The correct use of getProperty is:
>
> 
> Property<Foo> f = task->getProperty("foo");
> if (f.ready() ) {...}
>

Does this work for any Foo class type or only for the ones registered to the
typesystem, or only for the basic types?

Ruben

> There is a function 'getPropertyType<T>' in the ConfigurationInterface
> which does take a template parameter. Using that function should however
> not be needed given the above usage pattern.
>
> Peter

»

Feedback on a06d9eaf on dfki-rtt

Submitted by Sylvain Joyeux on Mon, 2010-11-15 15:24.

On 11/15/2010 04:07 PM, Peter Soetens wrote:
> This patch:
>
> 

> commit a06d9eaf33545c5888f9a8848bc88baf01b88f9e
> Author: Sylvain Joyeux<sylvain.joyeux@m4x.org>
> Date:   Fri Nov 12 23:25:29 2010 +0100
>
>      core: define TaskContext::getProperty<T>
>
> diff --git a/rtt/TaskContext.hpp b/rtt/TaskContext.hpp
> index b1f53b2..871ee94 100644
> --- a/rtt/TaskContext.hpp
> +++ b/rtt/TaskContext.hpp
> @@ -479,6 +479,19 @@ namespace RTT
>           }
>
>           /**
> +         * Get a Property with name \a name.
> +         *
> +         * @param  name The name of the property to search for.
> +         * @return The Property with this name, zero
> +         *         if it does not exist
> +         */
> +        template<typename T>
> +        Property<T>* getProperty(const std::string&  name) const
> +        {
> +            return dynamic_cast<Property<T>*>(tcservice->getProperty(name));
> +        }
> +
> +        /**
>            * Returns the properties of this TaskContext as a PropertyBag.
>            */
>           PropertyBag* properties() { return this->provides()->properties(); }
>

>
> Can't be accepted because getProperty() may not take a template parameter by
> 2.x naming conventions (see also: getPort() and getOperation() ).
> The correct use of getProperty is:
>
> 
> Property<Foo>  f = task->getProperty("foo");
> if (f.ready() ) {...}
>

>
> There is a function 'getPropertyType<T>' in the ConfigurationInterface which
> does take a template parameter. Using that function should however not be
> needed given the above usage pattern.
Ah. That's a quite uncommon usage pattern (doing automatic convertion at
assignation time), so I did not think about it.

If it is fine with you, I'll revert it with the following explanation
added in the commit message. I'd like to avoid rebasing.

»

Feedback on a06d9eaf on dfki-rtt

Submitted by peter on Mon, 2010-11-15 15:32.

On Monday 15 November 2010 16:20:32 Sylvain Joyeux wrote:
> On 11/15/2010 04:07 PM, Peter Soetens wrote:
> > This patch:
> >
> > 

> > commit a06d9eaf33545c5888f9a8848bc88baf01b88f9e
> > Author: Sylvain Joyeux<sylvain.joyeux@m4x.org>
> > Date:   Fri Nov 12 23:25:29 2010 +0100
> > 
> >      core: define TaskContext::getProperty<T>
> > 
> > diff --git a/rtt/TaskContext.hpp b/rtt/TaskContext.hpp
> > index b1f53b2..871ee94 100644
> > --- a/rtt/TaskContext.hpp
> > +++ b/rtt/TaskContext.hpp
> > @@ -479,6 +479,19 @@ namespace RTT
> > 
> >           }
> >           
> >           /**
> > 
> > +         * Get a Property with name \a name.
> > +         *
> > +         * @param  name The name of the property to search for.
> > +         * @return The Property with this name, zero
> > +         *         if it does not exist
> > +         */
> > +        template<typename T>
> > +        Property<T>* getProperty(const std::string&  name) const
> > +        {
> > +            return
> > dynamic_cast<Property<T>*>(tcservice->getProperty(name)); +        }
> > +
> > +        /**
> > 
> >            * Returns the properties of this TaskContext as a PropertyBag.
> >            */
> >           
> >           PropertyBag* properties() { return
> >           this->provides()->properties(); }
> > 
> >

> >
> > Can't be accepted because getProperty() may not take a template parameter
> > by 2.x naming conventions (see also: getPort() and getOperation() ). The
> > correct use of getProperty is:
> >
> > 
> > Property<Foo>  f = task->getProperty("foo");
> > if (f.ready() ) {...}
> >

> >
> > There is a function 'getPropertyType<T>' in the ConfigurationInterface
> > which does take a template parameter. Using that function should however
> > not be needed given the above usage pattern.
>
> Ah. That's a quite uncommon usage pattern (doing automatic convertion at
> assignation time), so I did not think about it.
>
> If it is fine with you, I'll revert it with the following explanation
> added in the commit message. I'd like to avoid rebasing.

No problem for me.

Peter

»