The next-virtual-clocks branch changes the static
TimerInstance::ticks2nsecs/nsecs2tics to a virtual function.
We can't have this API change on the 1.x line. It would have been better to
keep that function static and define
a new one that is virtual and to be used in the virtual clocks case. The
default implementation of the static ticks2nsecs could call the default
Instance() to do the conversion.
So I can't merge this code yet on trunk. This rule holds for every change on
the 1.x line.
Peter
snrkiwi/next-virtual-clocks API changes
On Jun 19, 2010, at 03:58 , Peter Soetens wrote:
> The next-virtual-clocks branch changes the static TimerInstance::ticks2nsecs/nsecs2tics to a virtual function.
> We can't have this API change on the 1.x line. It would have been better to keep that function static and define
> a new one that is virtual and to be used in the virtual clocks case. The default implementation of the static ticks2nsecs could call the default Instance() to do the conversion.
>
> So I can't merge this code yet on trunk. This rule holds for every change on the 1.x line.
>
> Peter
I wondered about that. Ok, I'll change it as you requested and send a pull request after that.
Once we have a v2 that builds on the Mac, I'll propgate changes like this there as well.
S
snrkiwi/next-virtual-clocks API changes
On Jun 19, 2010, at 08:46 , S Roderick wrote:
> On Jun 19, 2010, at 03:58 , Peter Soetens wrote:
>
>> The next-virtual-clocks branch changes the static TimerInstance::ticks2nsecs/nsecs2tics to a virtual function.
>> We can't have this API change on the 1.x line. It would have been better to keep that function static and define
>> a new one that is virtual and to be used in the virtual clocks case. The default implementation of the static ticks2nsecs could call the default Instance() to do the conversion.
>>
>> So I can't merge this code yet on trunk. This rule holds for every change on the 1.x line.
>>
>> Peter
>
> I wondered about that. Ok, I'll change it as you requested and send a pull request after that.
Fixed. Please try "next-virtual-clocks" in RTT.
Stephen