[Bug 509] New: New ImageDisplayComponent based on ReporterComponent

For more infomation about this bug, visit
Summary: New ImageDisplayComponent based on ReporterComponent
Product: OCL
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: project
Priority: P2
Component: Other
AssignedTo: orocos-dev [..] ...
ReportedBy: francois [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

Created an attachment (id=229)
--> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=229)
New ImageDisplayComponent based on ReporterComponent

I made a component that allows to display multiple IplImage dataports of
different Components. This code is based on the Reporter component.

Ruben Smits's picture

[Bug 509] New ImageDisplayComponent based on ReporterComponent

For more infomation about this bug, visit

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
AssignedTo|orocos- |francois [..] ...
|dev [..] ... |
CC| |ruben [dot] smits [..] ...
Depends on| |496

--- Comment #3 from Ruben Smits <ruben [dot] smits [..] ...> 2008-01-31 11:19:03 ---
i committed this patch in ocl/vision, further reviews and comments are still
accepted.

Ruben

[Bug 509] New ImageDisplayComponent based on ReporterComponent

On Jan 31, 2008 11:19 AM, Ruben Smits <ruben [dot] smits [..] ...> wrote:
> For more infomation about this bug, visit
[...]
> --- Comment #3 from Ruben Smits <ruben [dot] smits [..] ...> 2008-01-31 11:19:03 ---
> i committed this patch in ocl/vision, further reviews and comments are still
> accepted.

Wouldn't it be a good idea to create a branch for the vision
components, as explained in
Then authors can commit more freely their code. Once all "OCL
inclusion" criteria are met, we can then merge the branch to ocl
trunk.

Klaas

[Bug 509] New ImageDisplayComponent based on ReporterComponent

For more infomation about this bug, visit

--- Comment #2 from François Cauwe <francois [..] ...> 2008-01-30 19:47:28 ---
Because I didn't know it existed :)
I will check it out, thanks for the comment.

There seems still something weird, when I attach more than 1 camera, which is
the purpose of this Component, I get everywhere the same image. I don't know if
it's opencv related or not.

But I'm not completely sure of this part of the code, can someone review it?

void ImageDisplayComponent::updateHook()
+ {
+ // For every dataport
+ for(Reports::iterator it = root.begin(); it != root.end(); ++it ) {
+ // Update the dataport
+ (it->get<2>())->execute();
+ // Get the base dataport
+ DataSourceBase::shared_ptr source = it->get<3>();
+ // Convert to Dataport
+ DataSource::shared_ptr clone =
AdaptDataSource()( source.get() );
+ IplImage localImage = clone->get();
+ string dataportName = it->get<0>();
+ cvShowImage(dataportName.data(),&localImage);
+ }

[Bug 509] New ImageDisplayComponent based on ReporterComponent

For more infomation about this bug, visit

Klaas Gadeyne <klaas [dot] gadeyne [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
CC| |klaas [dot] gadeyne [..] ...

--- Comment #1 from Klaas Gadeyne <klaas [dot] gadeyne [..] ...> 2008-01-29 20:14:43 ---
(In reply to comment #0)
> Created an attachment (id=229)
--> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=229) [details]
> New ImageDisplayComponent based on ReporterComponent
>
> I made a component that allows to display multiple IplImage dataports of
> different Components. This code is based on the Reporter component.

I've only had a first quick glance at the code, but in your documentation I
read that the component is meant to display images periodically in non
real-time. If so, why didn't you attach a non-realtime PeriodicActivity to the
component immediately?