On Thursday 05 June 2008 13:50:47 Ruben Smits wrote:
> On Thursday June 5 2008 13:25:37 Ruben Smits wrote:
> > On Thursday June 5 2008 10:39:33 Peter Soetens wrote:
> > > For more infomation about this bug, visit
> > >
> > >
> > > Peter Soetens
<peter [dot] soetens [..] ...> changed:
> > >
> > > What |Removed |Added
> > >
> > > -----------------------------------------------------------------------
> > >-- - Status|NEW |RESOLVED
> > > Resolution| |FIXED
> > >
> > >
> > >
> > > --- Comment #2 from Peter Soetens
<peter [dot] soetens [..] ...> 2008-06-05
> > > 10:39:33 --- $ svn di src/scripting/
> > > Index: src/scripting/PeerParser.cpp
> > > ===================================================================
> > > --- src/scripting/PeerParser.cpp (revision 29354)
> > > +++ src/scripting/PeerParser.cpp (working copy)
> > > @@ -178,7 +178,8 @@
> > > // do not consume it though.
> > > //cout << std::string(begin, end +10)< > > > mlastobject = name;
> > > - mcurobject = 0;
> > > + if (mfullpath)
> > > + mcurobject = 0; //when partial paths are OK, leave
> > > curobject pointing to last valid object.
> > > throw_(begin, peer_not_found );
> > > }
> > > }
> > >
> > > This bug was introduced due to the fix for bug#557.
> > > The unit tests did not cover dot operators...
> > >
> > > $ svn ci tests/types_test.* src/scripting/PeerParser.cpp -m"Fixes bug
> > > #563: scripting support for array broken
> > > return last object of partial path if partial is ok.
> > > "
> > > Sending src/scripting/PeerParser.cpp
> > > Sending tests/types_test.cpp
> > > Sending tests/types_test.hpp
> > > Transmitting file data ...
> > > Committed revision 29361.
> >
> > the test passes, but i still get the same wrong behaviour when loading
> > the scripts in the deployer. I did a make clean;make;make install in rtt
> > and ocl
>
> Some more information: i'm trying to load the following script in the
> deployer:
> ----
> 1 StateMachine test{
> 2 initial state Init{
> 3 run{
> 4 var array ar1(3)

This line is correct

> 5 var array ar2(2,3.0)
> 6 var array ar3(1.0,2.0,3.0)

These two lines are not correct. The scripting language interpretes the first
case as a 'size hint' and creates an array of size 3. The second cases are
not accepted.

You need to write:

var array ar2(2) = array(2,3.0)
var array ar3(3) = array(1.0,2.0,3.0)

We should have used maybe [] for the size hint instead of ()...

Peter

> 7 }}
> 8 final state Final{}
> 9 }
> 10 RootMachine test test
> ----
> and i get the following error:
> [ ERROR ][ParserScriptingAccess::loadStateMachine] test.ops :Parse error
> at line 5: Syntactic error: Closing brace expected (or could not find out
> what this line means).
>
> typing these constructors directly in the taskbrowser works perfectly
>
> Ruben

On Thursday June 5 2008 09:38:12 Peter Soetens wrote:
> On Thursday 05 June 2008 09:29:07 Ruben Smits wrote:
> > The constructor syntax works correctly in the taskbrowser, the dot
> > operators don't.
> >
> > Added following tests:
> > //30:
> > "var array ar1(12,2.0)"+
> > "do test.assert(ar1.size == 12)"+
> > "do test.assert(ar1[0] == 2.0)"+
> > "var array ar2 = array(5,3.0)"+
> > "do test.assert(ar2.size == 5)"+
> > "do test.assert(ar2[0] == 3.0)"+
> > "var array ar3(2.0,3.0,4.0)"+
> > "do test.assert(ar3.size == 3)"+
> > "do test.assert(ar3[0]==2.0)"+
> > "do test.assert(ar3[1]==3.0)"+
> > //40:
> > "do test.assert(ar3[2]==4.0)"+
> > "var array ar4 = array(2.0,3.0,4.0,5.0)"+
> > "do test.assert(ar4.size == 4)"+
> > "do test.assert(ar4[0]==2.0)"+
> > "do test.assert(ar4[1]==3.0)"+
> > "do test.assert(ar4[2]==4.0)"+
> > "do test.assert(ar4[3]==5.0)"+
>
> These tests are not correct. You omitted the \n... in practice you passed

They are indeed not correct in the mail, but they are in the test ;) check the
commit if you want. Sorry for the confusion.

> var array ar1(12,2.0)do test.assert(ar1.size == 12)do test.assert(ar1[0]
> ==2.0)....
>
> to the parser.

So the bug is still out there ...

Ruben