[Bug 568] New: Missing stdlib.h inclusions

Submitted by Sylvain Joyeux on Tue, 2008-06-10 13:41

For more infomation about this bug, visit
Summary: Missing stdlib.h inclusions
Product: RTT
Version: rtt-trunk
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Real-Time Toolkit (RTT)
AssignedTo: orocos-dev [..] ...
ReportedBy: sylvain [dot] joyeux [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

Two files miss a stdlib.h (manpages says malloc and free are defined in
stdlib.h for instance).

See attached patch (I hope this one will go through)

‹ ocl for Stäubli [Bug 565] New: Periodicity of thread not guaranteed under (preempt-rt) gnulinux ›
»

[Bug 568] Missing stdlib.h inclusions

Submitted by Leopold Palomo-... on Tue, 2008-06-10 14:35.

For more infomation about this bug, visit

Leopold Palomo <leo [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
CC| |leo [..] ...

--- Comment #3 from Leopold Palomo <leo [..] ...> 2008-06-10 16:05:03 ---
Please put
#include

instead of

#include

»

[Bug 568] Missing stdlib.h inclusions

Submitted by sspr on Tue, 2008-06-10 14:20.

For more infomation about this bug, visit

--- Comment #4 from Peter Soetens
<peter [dot] soetens [..] ...> 2008-06-10 16:11:39 ---
As Leo pointed out off-list, we need to be more picky regarding C++
compliance...

$ svn di src/os
Index: src/os/rtconversions.cpp
===================================================================
--- src/os/rtconversions.cpp (revision 29377)
+++ src/os/rtconversions.cpp (working copy)
@@ -38,7 +38,7 @@
#include "os/rtconversions.hpp"

#include
-#include
+#include

using namespace std;

Index: src/os/gnulinux/fosi_internal.cpp
===================================================================
--- src/os/gnulinux/fosi_internal.cpp (revision 29377)
+++ src/os/gnulinux/fosi_internal.cpp (working copy)
@@ -44,7 +44,7 @@
#include
#include
#include
-#include
+#include
using namespace std;

#define INTERNAL_QUAL
+ sspr@lt00129:~/src/Orocos/trunk/rtt

$ svn ci src/os -m"Purified previous patch by using the C++ headers instead of
the C headers."
Sending src/os/gnulinux/fosi_internal.cpp
Sending src/os/rtconversions.cpp
Transmitting file data ..
Committed revision 29378.

»

[Bug 568] Missing stdlib.h inclusions

Submitted by sspr on Tue, 2008-06-10 14:10.

For more infomation about this bug, visit

Peter Soetens
<peter [dot] soetens [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
CC| |peter [dot] soetens [..] ...

--- Comment #2 from Peter Soetens
<peter [dot] soetens [..] ...> 2008-06-10 16:00:11 ---
Patch applied on trunk/rtt. Small patches like these can/may be submitted to
orocos-dev without creating a bug report... Thanks!

$ svn ci src/os/gnulinux/fosi_internal.cpp src/os/rtconversions.cpp -m"Applied
patch from bug #568: Missing stdlib.h inclusions by S. Joyeux."
Sending src/os/gnulinux/fosi_internal.cpp
Sending src/os/rtconversions.cpp
Transmitting file data ..
Committed revision 29377.

PS: Normally you can add an attachment when the bug is created...?

»

[Bug 568] Missing stdlib.h inclusions

Submitted by Sylvain Joyeux on Tue, 2008-06-10 13:50.

For more infomation about this bug, visit

--- Comment #1 from Sylvain Joyeux <sylvain [dot] joyeux [..] ...> 2008-06-10 15:42:02 ---
Created an attachment (id=319)
--> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=319)
patch fixing the issues

»