[Bug 599] New: Copy past error in Simulate method of MeasurementModel

For more infomation about this bug, visit
Summary: Copy past error in Simulate method of MeasurementModel
Product: BFL
Version: 0.6.1
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P1
Component: core
AssignedTo: tinne [dot] delaet [..] ...
ReportedBy: tinne [dot] delaet [..] ...
CC: bfl [..] ...
Estimated Hours: 0.0

Hi,

I have a question about version: BFL 0.6.1

The class MeasurementModel the following template method:

template MeasVar
MeasurementModel::Simulate (const StateVar& x,
const StateVar& s,
int sampling_method,
void * sampling_args)
{
assert(_systemWithoutSensorParams == false);
_MeasurementPdf->ConditionalArgumentSet(0,x);
_MeasurementPdf->ConditionalArgumentSet(1,s);
Sample Simulated(MeasurementSizeGet());
_MeasurementPdf->SampleFrom(Simulated, sampling_method,sampling_args);
MeasVar result = Simulated.ValueGet();
return result;
}

I am wondering if on the 4th line of the method Sample shouldn't
be replaced by Sample?

This because the grand-parent Pdf has the methode "bool SampleFrom
(Sample& one_sample, int method, void * args) const;"
Where T is MeasVar in the measurementmodel!

Same issue occur in the other Simulate method of the class MeasurementModel

Is it wrong, or did I missed something?

With best regards,

Jürge

[Bug 599] Copy past error in Simulate method of MeasurementModel

For more infomation about this bug, visit

Tinne De Laet <tinne [dot] delaet [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #2 from Tinne De Laet <tinne [dot] delaet [..] ...> 2008-12-03 09:19:36 ---
svn commit
Sending model/measurementmodel.cpp
Transmitting file data .
Committed revision 29764.

[Bug 599] Copy past error in Simulate method of MeasurementModel

For more infomation about this bug, visit

--- Comment #1 from Tinne De Laet <tinne [dot] delaet [..] ...> 2008-12-03 09:13:11 ---
Created an attachment (id=354)
--> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=354)
this patch solves bug#599