On Tuesday 06 April 2010 09:23:47 Ruben Smits wrote:
> On Tuesday 30 March 2010 16:56:09 Alexis Maldonado wrote:
> > Hi *,
> >
> > We use fairly updated Debian Sid machines at the lab, that come with
> > CMake version 2.8.1 and SIP version 4.10.1.
> >
> > The current check for SIP uses a string comparison to check if SIP is at
> > least version 4.7.9, but it fails with 4.10.x.
>
> Strange I'm using cmake 2.8.0 with SIP 4.10.1 and detection succeeds
> on my machine with kdl-trunk. I'll look into it.

I spoke to early, I applied your patch in kdl trunk:

svn ci CMakeLists.txt config/FindSIPandPython.cmake -m"Fixing detection of SIP
4.10.1 and require cmake 2.6 from now on"
Sending CMakeLists.txt
Sending config/FindSIPandPython.cmake
Transmitting file data ..
Committed revision 31585.

Thanks for sending the patch

R.

> Ruben
>
> > Example: (Part of the config/FindSIPandPython.cmake file)
> > SET (SIP_MIN_VERSION 040709)
> > IF (SIP_VERSION EQUAL "${SIP_MIN_VERSION}" OR SIP_VERSION GREATER
> > "${SIP_MIN_VERSION}")
> >
> > There is better support for version comparison starting with CMake 2.6.
> > Would you consider asking for CMake 2.6 as a requirement? In case you do,
> > I'm attaching a patch that uses the new version comparison commands.
> >
> > Then you could do it like this:
> > SET (SIP_MIN_VERSION "4.7.9")
> > IF (${SIP_VERSION} VERSION_EQUAL "${SIP_MIN_VERSION}" OR ${SIP_VERSION}
> > VERSION_GREATER "${SIP_MIN_VERSION}")
> >
> > CMake 2.4.7 was released in July 2007 and and 2.6.0 in May 2008. Maybe it
> > has been enough time to get CMake 2.6 on all normal development machines.
> >
> > Greetings!
> >
> > Alexis Maldonado
> > TU-Muenchen