[patch] log4cpp: Add threading support in CMake logic for win32 threads and pthreads

Submitted by phamelin on Fri, 2011-10-07 09:28

Hello,

I would like to submit this patch to log4cpp :

https://github.com/phamelin/orocos-log4cpp/commit/c7ea92fb685b96ef5169d4...

It enables threading support in the CMake logic in order to correctly use
the %t pattern to show the id of the thread which produced the log. In other
words, the 'getThreadId()'method doesn't returns a dummy name anymore.

Philippe

‹ Orocos website theme for Drupal 6 Small report of the developers get-together at IROS...? ›
»

[patch] log4cpp: Add threading support in CMake logic for win32

Submitted by snrkiwi on Sat, 2011-10-08 13:48.

On Oct 3, 2011, at 08:46 , Philippe Hamelin wrote:

> 2011/10/2 S Roderick <kiwi [dot] net [..] ...>
> On Sep 30, 2011, at 10:07 , Philippe Hamelin wrote:
>
>> Hello,
>>
>> I would like to submit this patch to log4cpp :
>>
>> https://github.com/phamelin/orocos-log4cpp/commit/c7ea92fb685b96ef5169d4...
>>
>> It enables threading support in the CMake logic in order to correctly use the %t pattern to show the id of the thread which produced the log. In other words, the 'getThreadId()'method doesn't returns a dummy name anymore.
>>
>> Philippe
>
> Works for me. Can you please recommit with "sign off" attached. Might pay to prefix the commit message with "cmake: " also
>
>
>
> Hello Stephen,
>
> Here is the new patch.
>
> Philippe
>
> <0001-Add-threading-support-in-CMake-logic-for-win32-threa.patch>

I have pushed this to master. I added a small patch to remove the explicit pthread flag that was still set for Linux. Tested fine on Ubuntu 10.04

I have also pushed some other small cmake fixes, including producing the API doc's with Doxygen.
S

»